Migrate legacy (already removed) scripts to auroraboot commands #201
+848
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we switched to using auroraboot as the tool-image, these scripts no longer exist. The functionality is provided by auroraboot itself. Fixes kairos-io/kairos#3779 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
force-pushed
the
3779-fix-cloud-image-building
branch
from
fbebc7e to
95888ab
Compare
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
force-pushed
the
3779-fix-cloud-image-building
branch
3 times, most recently
from
354e08c to
0ac0589
Compare
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
force-pushed
the
3779-fix-cloud-image-building
branch
from
0ac0589 to
35f18ca
Compare
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
so that the netboot container finds the ISO in place when it needs it Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
There was a problem hiding this comment.
Pull request overview
This PR migrates legacy shell scripts to auroraboot commands after switching to auroraboot as the tool-image. The scripts (/raw-images.sh, /azure.sh, /gce.sh, /netboot.sh) have been removed and replaced with direct auroraboot command invocations.
Key changes:
- Replaced legacy script calls with auroraboot CLI commands for cloud image, Azure, GCE, and netboot builds
- Refactored e2e test helpers into shared TestClients struct to reduce code duplication
- Added comprehensive e2e tests for different artifact formats (CloudImage, Netboot, AzureImage, GCEImage)
- Enhanced controller tests to verify correct auroraboot command generation
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| controllers/job.go | Replaced legacy shell script calls with auroraboot commands for cloud image, Azure, GCE, and netboot builds |
| controllers/osartifact_controller.go | Added PVC existence check to handle race conditions |
| controllers/osartifact_controller_test.go | Added comprehensive tests for auroraboot command generation and removed manager setup in favor of direct client |
| controllers/suite_test.go | Added default service account creation and namespace deletion waiting for test isolation |
| tests/e2e/e2e_suite_test.go | Extracted common test functionality into TestClients helper struct |
| tests/e2e/e2e_simple_test.go | Refactored to use TestClients helper methods |
| tests/e2e/e2e_formats_test.go | Added new e2e tests for CloudImage, Netboot, AzureImage, and GCEImage formats |
| Makefile | Added conditional check to avoid re-downloading kustomize |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7 tasks
|
@jimmykarily I've opened a new pull request, #203, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Refactor command string to use strings.Builder for better readability Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com> * Complete refactoring of command string Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com> * Refactor azureCmd and gceCmd to use strings.Builder Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com> * Revert unintended changes to generated files Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jimmykarily <2794419+jimmykarily@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmidyson
reviewed
Dec 3, 2025
Co-authored-by: Jimmi Dyson <jimmi.dyson@nutanix.com> Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
mauromorales
reviewed
Dec 4, 2025
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched to using auroraboot as the tool-image, these scripts no longer exist. The functionality is provided by auroraboot itself.
Fixes kairos-io/kairos#3779